This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix UT workflow to only run bootstrap once #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you quickly do small smoke test to verify if UI is working without anything broken? looks like many dependencies are upgraded. |
yes, I've done this. don't see anything broken |
Cool. |
yizheliu-amazon
approved these changes
Jun 9, 2020
ylwu-amzn
approved these changes
Jun 9, 2020
This was referenced Jun 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #75
Description of changes:
This PR fixes the bug where running
yarn kbn bootstrapwould occasionally fail the first time and would have to be ran twice (on both the GitHub runners and on a local dev environment).Specific changes:
yarn.lockby runningyarn upgradeto upgrade all dependencies. This fixes the bootstrap failing issue.Notes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.