This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Initial test case using Cypress #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
reviewed
Jun 3, 2020
Comment on lines
+31
to
+35
| // Import commands.js using ES2015 syntax: | ||
| // import './commands'; | ||
|
|
||
| // Alternatively you can use CommonJS syntax: | ||
| // require('./commands') |
There was a problem hiding this comment.
Is everything commented out here because we have no modified configuration/behavior yet?
There was a problem hiding this comment.
Yeah. It is more like a placeholder for now.
ohltyler
reviewed
Jun 3, 2020
package.json
Outdated
| "start-cy-server": "yarn start --no-base-path --oss", | ||
| "cy:open": "cypress open", | ||
| "cy:run": "cypress run", | ||
| "e2e:test": "WAIT_ON_TIMEOUT=900000 start-server-and-test 'yarn start-cy-server' http-get://localhost:5601/app/opendistro-anomaly-detection-kibana 'yarn cy:run'" |
There was a problem hiding this comment.
do we test by running yarn e2e:test?
There was a problem hiding this comment.
In the upcoming CI change, it will be used.
Closed
ylwu-amzn
reviewed
Jun 3, 2020
| * permissions and limitations under the License. | ||
| */ | ||
|
|
||
| /// <reference types="cypress" /> |
There was a problem hiding this comment.
This is needed to enable Intelligent Code Completion in IDE: https://docs.cypress.io/guides/tooling/IDE-integration.html#Triple-slash-directives
|
Can you explain how to run integration test in readme? |
sure. will add it. |
ohltyler
approved these changes
Jun 4, 2020
ylwu-amzn
approved these changes
Jun 4, 2020
mihirsoni
reviewed
Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Initial test case using Cypress. CI will be configured as next step. And more tests will be added.
Testing:
Screenshot:
Command: yarn cy:open
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.