Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix anomaly results pagination #180

Merged

Conversation

ohltyler
Copy link
Contributor

Issue #, if available: #179

Description of changes:

This PR fixes the pagination on the anomaly results table and makes it consistent with pagination on detector list table. Changes include:

  1. Don't show top pagination if only 1 page of results
  2. Show pagination with multiple pages if there are multiple pages of results

After:
Screen Shot 2020-05-26 at 12 15 09 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ohltyler ohltyler linked an issue May 26, 2020 that may be closed by this pull request
Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix

@ohltyler ohltyler merged commit 0e89217 into opendistro-for-elasticsearch:master May 26, 2020
@ohltyler ohltyler deleted the fixPagination branch May 26, 2020 19:42
ohltyler added a commit that referenced this pull request May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination not displaying properly on anomaly results table
3 participants