This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Handle error on detector detail pages #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
commented
May 21, 2020
| @@ -94,7 +94,7 @@ const reducer = handleActions<Detectors>( | |||
| FAILURE: (state: Detectors, action: APIErrorAction): Detectors => ({ | |||
| ...state, | |||
| requesting: false, | |||
| errorMessage: action.error.data.error, | |||
| errorMessage: action.error, | |||
There was a problem hiding this comment.
This line here was causing an exception. data was undefined, which caused the error to be thrown. Because of this, the ad state never got out of requesting and was preventing the detector details pages from handling the error and redirecting to the detector list page.
yizheliu-amazon
approved these changes
May 21, 2020
ylwu-amzn
approved these changes
May 21, 2020
ohltyler
added a commit
that referenced
this pull request
May 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #172
Description of changes:
Handles errors when an invalid detector id is passed to the detector detail pages (results and configuration pages). This could be caused by changing the url directly, or refreshing a stale page if the detector has been deleted in another window.
Before (infinite loading state):
After (redirects to detector list page, toast displaying error):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.