This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Update detector list page & add profile API #16
Merged
ohltyler
merged 8 commits into
opendistro-for-elasticsearch:development
from
ohltyler:updateDetectorListPage
Apr 16, 2020
Merged
Update detector list page & add profile API #16
ohltyler
merged 8 commits into
opendistro-for-elasticsearch:development
from
ohltyler:updateDetectorListPage
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
force-pushed
the
updateDetectorListPage
branch
5 times, most recently
from
April 3, 2020 18:54
41b136e
to
d93d70c
Compare
ylwu-amzn
reviewed
Apr 3, 2020
ohltyler
force-pushed
the
updateDetectorListPage
branch
from
April 3, 2020 23:14
fc38470
to
2b939ad
Compare
mihirsoni
reviewed
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ohltyler Thanks for the changes. Few comments.
ohltyler
force-pushed
the
updateDetectorListPage
branch
2 times, most recently
from
April 6, 2020 17:09
d482149
to
9b706c8
Compare
public/pages/DetectorsList/Components/ListControls/ListControls.tsx
Outdated
Show resolved
Hide resolved
ohltyler
force-pushed
the
updateDetectorListPage
branch
from
April 6, 2020 22:24
82bd8f5
to
5bf4dc5
Compare
|
ohltyler
force-pushed
the
updateDetectorListPage
branch
2 times, most recently
from
April 10, 2020 00:45
8f999d1
to
54e745e
Compare
ohltyler
changed the title
Update detector list page
[WIP] Update detector list page & add profile API
Apr 10, 2020
ohltyler
changed the title
[WIP] Update detector list page & add profile API
Update detector list page & add profile API
Apr 13, 2020
ohltyler
force-pushed
the
updateDetectorListPage
branch
from
April 13, 2020 18:38
80465d9
to
08cff3d
Compare
ylwu-amzn
reviewed
Apr 14, 2020
ylwu-amzn
reviewed
Apr 14, 2020
ylwu-amzn
reviewed
Apr 14, 2020
Merged
public/pages/DetectorsList/Components/ListControls/ListControls.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Apr 15, 2020
public/pages/DetectorsList/Components/ListControls/ListControls.tsx
Outdated
Show resolved
Hide resolved
mihirsoni
reviewed
Apr 15, 2020
mihirsoni
reviewed
Apr 15, 2020
ohltyler
force-pushed
the
updateDetectorListPage
branch
from
April 15, 2020 17:10
fe63261
to
565e981
Compare
mihirsoni
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for changes.
ohltyler
force-pushed
the
updateDetectorListPage
branch
from
April 15, 2020 17:43
d090a22
to
5b7782c
Compare
ylwu-amzn
approved these changes
Apr 15, 2020
yizheliu-amazon
approved these changes
Apr 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR modifies the previous detector list page:
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.