Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Fix unit test issue #14

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix unit test issue #14

merged 1 commit into from
Apr 3, 2020

Conversation

yizheliu-amazon
Copy link
Contributor

@yizheliu-amazon yizheliu-amazon commented Mar 30, 2020 •
edited
Loading

Issue #, if available:

*Description of changes:
Fix unit test issue.

Tests have been done:

  1. 'yarn test:jest'
Test Suites: 35 passed, 35 total
Tests:       1 skipped, 183 passed, 184 total
Snapshots:   13 passed, 13 total
Time:        37.359s
  1. 'yarn start' to do manual tests on browser to verify other functions are not broken
  2. run 'yarn build', and install it to binary oss version Kibana, then start Kibana to perform manual tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ylwu-amzn
ylwu-amzn approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@yizheliu-amazon yizheliu-amazon merged commit 5a5574a into opendistro-for-elasticsearch:development Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@kaituo kaituo kaituo approved these changes

@mihirsoni mihirsoni mihirsoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yizheliu-amazon @mihirsoni @kaituo @ylwu-amzn