Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add loading state for live chart on detector detail page #131

Merged
merged 2 commits into from
May 12, 2020

Conversation

ylwu-amzn
Copy link
Contributor

Issue #, if available:

Description of changes:

  • add loading state for live chart on detector detail page

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

@ylwu-amzn ylwu-amzn merged commit ca08a23 into opendistro-for-elasticsearch:1.4 May 12, 2020
Copy link
Contributor

@yizheliu-amazon yizheliu-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

ohltyler pushed a commit that referenced this pull request May 12, 2020
* add loading state for live chart on detector detail page

* remove unused import
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants