Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add start/stop AD job api #12

Merged

Conversation

ylwu-amzn
Copy link
Contributor

*Issue #11

Description of changes:
Add start/stop AD job apis

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

server/routes/ad.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would happen if the Job is already started, do we disable on UI also how does backend handle this ?

@ylwu-amzn
Copy link
Contributor Author

What would happen if the Job is already started, do we disable on UI also how does backend handle this ?

Will disable update on UI and we have check from backend, will block updating detector if job is running.

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ylwu-amzn ylwu-amzn merged commit e7c4cb2 into opendistro-for-elasticsearch:development Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants