This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix issue of not resetting to first page when applying filters #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizheliu-amazon
approved these changes
May 8, 2020
ylwu-amzn
approved these changes
May 8, 2020
yizheliu-amazon
pushed a commit
that referenced
this pull request
May 8, 2020
* Reset to first page when filter change * Add test case
yizheliu-amazon
pushed a commit
that referenced
this pull request
May 8, 2020
* Reset to first page when filter change * Add test case
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
On the detector list page, if user is on a page other than the first page and applies a filter, it may show no detectors even if some exist with the filter applied. This is because the page is not reset to the first page when a filter is applied. This fixes that issue, and will reset the page to the first page for the 4 possible filter changes:
Before:
After:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.