Adding HTTP Input type for monitors #82

ann3431 · 2019-07-16T22:34:52Z

*Issue #, if available: #47

*Description of changes:

Adding new type of input HttpInput for monitors.

MonitorRunner class creates a HttpInputClient when collecting input results of an HttpInput.

Changes to README file regarding setting JAVA_HOME.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

> > Configure project :alerting
=======================================
Elasticsearch Build Hamster says Hello!
  Gradle Version        : 5.2.1
  OS Info               : Mac OS X 10.14.5 (x86_64)
  JDK Version           : 12 (Oracle Corporation 12.0.1 [Java HotSpot(TM) 64-Bit Server VM 12.0.1+12])
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-12.0.1.jdk/Contents/Home
  Random Testing Seed   : 9087A73AD72ABD1
=======================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 1m 49s
52 actionable tasks: 30 executed, 22 up-to-date

ghost

We also need some limit on response size as over-large responses can take down the cluster.

README.md

alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunner.kt

...rc/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/httpapi/HttpExtensions.kt

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/client/HttpInputClient.kt

core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/HttpInput.kt

core/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/HttpInputTest.kt

Changed to isEmpty()

Fix typo

Also added test.

Multiply by 1000 in toGetRequest function to convert to ms

ann3431 · 2019-07-19T01:47:41Z

We also need some limit on response size as over-large responses can take down the cluster.

@vinooamzn There is no out of box function for the client to limit response size. The way I can think of preventing this problem is to restrict the maximum timeout value so that large amount of data cannot be transmitted in limited time. Do you know any good way to limit the content size?

Revisions on several issues: - Reusing client in `MonitorRunner` - Allowing only port 9200 for localhost in `HttpInput` - Fixed typo in `README.md` - Validation only one of url or scheme+host+port+path+params is set in `HttpInput`. - Set maximum timeout values to 60s and updated tests.

ann3431

Limiting response size to 100MB in MonitorRunner.collectInputResult().

alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunner.kt

...rc/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/httpapi/HttpExtensions.kt

alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunnerIT.kt

core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/HttpInput.kt

Move port validation from HttpInput to RestIndexMonitorAction. Validation funtion ensures that the port number for localhost is restricted to the default port specified in settings.

ann3431

Resolved

…-for-elasticsearch#82)" This reverts commit c2004f7.

* Revert "Adding new type of input for Monitors - HttpInput (#82)" This reverts commit c2004f7.

…-for-elasticsearch#82)" This reverts commit c2004f7.

This reverts commit c2004f7.

* Add http method to custom webhook * Remove unused line * Opendistro 1.3 * Revert "Adding new type of input for Monitors - HttpInput (#82)" This reverts commit c2004f7. * fix alerting stats API (#129) * Bump plugin version (#131) * Restrict custom http alert method to POST PUT and PATCH * Fix indenting * Fix indention * Fix additional indention Co-authored-by: Jason Leezer <[email protected]> Co-authored-by: Lucas Winkelmann <[email protected]> Co-authored-by: Jinsoo <[email protected]> Co-authored-by: Mohammad Qureshi <[email protected]>

Closes #82

This reverts commit c2004f7.

* Add http method to custom webhook * Remove unused line * Opendistro 1.3 * Revert "Adding new type of input for Monitors - HttpInput (#82)" This reverts commit c2004f7. * fix alerting stats API (#129) * Bump plugin version (#131) * Restrict custom http alert method to POST PUT and PATCH * Fix indenting * Fix indention * Fix additional indention Co-authored-by: Jason Leezer <[email protected]> Co-authored-by: Lucas Winkelmann <[email protected]> Co-authored-by: Jinsoo <[email protected]> Co-authored-by: Mohammad Qureshi <[email protected]>

Adding HttpInput

38d2c20

lucaswin-amzn requested review from lucaswin-amzn, a user, dbbaughe and jinsoor-amzn July 16, 2019 22:54

ghost suggested changes Jul 17, 2019

View reviewed changes

ann3431 added 10 commits July 17, 2019 16:27

Update HttpInput.kt

ffbff35

Changed to isEmpty()

Update README.md

67ff5fe

Fix typo

Added field validation in HttpInput and test

00de8d1

Merge branch 'dev' of https://github.com/ann3431/alerting into dev

cc1821a

Update HttpExtensions.kt

8e7a44a

Implementation of reusing AsyncClient

a9a0596

Restrict port of localhost to 9200

5ff1f9f

Also added test.

Changed timeout values to units of sec

312c93e

Multiply by 1000 in toGetRequest function to convert to ms

Update HttpInput.kt

d6cffe1

Merge branch 'reuse-client' into dev

6bb598d

ann3431 added 5 commits July 18, 2019 18:54

Fixed timeout values in tests

97c897e

Change max connection timeout to 5s, close Client

cd30e8c

Limit response size and closing client

01fcb38

Merge branch 'dev'

005b5c2

ann3431 commented Jul 19, 2019

View reviewed changes

ghost reviewed Jul 24, 2019

View reviewed changes

ann3431 added 3 commits July 24, 2019 11:06

Change log level to debug

f8dbc8f

Finished async implementation

0d08d15

Merge branch 'async'

7aeb3be

jinsoor-amzn reviewed Jul 26, 2019

View reviewed changes

core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/HttpInput.kt Outdated Show resolved Hide resolved

ann3431 added 2 commits July 30, 2019 17:03

Moved port validation logic to RestIndexMonitorAction

3e1dcc3

Move port validation from HttpInput to RestIndexMonitorAction. Validation funtion ensures that the port number for localhost is restricted to the default port specified in settings.

Style fix

9f750b3

ann3431 commented Aug 1, 2019

View reviewed changes

lucaswin-amzn merged commit c2004f7 into opendistro-for-elasticsearch:master Aug 1, 2019

lucaswin-amzn added a commit to lucaswin-amzn/alerting that referenced this pull request Nov 18, 2019

Revert "Adding new type of input for Monitors - HttpInput (opendistro…

44ef91b

…-for-elasticsearch#82)" This reverts commit c2004f7.

lucaswin-amzn added a commit that referenced this pull request Nov 19, 2019

Opendistro 1.3

edd6766

* Revert "Adding new type of input for Monitors - HttpInput (#82)" This reverts commit c2004f7.

dbbaughe added a commit to dbbaughe/alerting that referenced this pull request Jan 31, 2020

Revert "Adding new type of input for Monitors - HttpInput (opendistro…

45fb88d

…-for-elasticsearch#82)" This reverts commit c2004f7.

dbbaughe added a commit to dbbaughe/alerting that referenced this pull request Jan 31, 2020

Revert "Adding new type of input for Monitors - HttpInput (opendistro…

d860cc2

…-for-elasticsearch#82)" This reverts commit c2004f7.

dbbaughe added a commit that referenced this pull request Jan 31, 2020

Revert "Adding new type of input for Monitors - HttpInput (#82)" (#162)

7675df8

This reverts commit c2004f7.

dbbaughe added a commit that referenced this pull request Jan 31, 2020

Revert "Adding new type of input for Monitors - HttpInput (#82)" (#161)

2ba45e5

This reverts commit c2004f7.

ftianli-amzn mentioned this pull request Jul 2, 2020

Add a new input type for monitors - HttpInput (Inherited from PR #82) #220

Closed

anirudha changed the title ~~Adding new type of input for Monitors - HttpInput~~ Adding HttpInput type for monitors Jul 8, 2020

anirudha changed the title ~~Adding HttpInput type for monitors~~ Adding Http Input type for monitors Jul 8, 2020

praveensameneni added alerting Item related to Alerting enhancement New feature or request labels Aug 5, 2020

jcgraybill changed the title ~~Adding Http Input type for monitors~~ Adding HTTP Input type for monitors Oct 1, 2020

tlfeng pushed a commit that referenced this pull request Feb 6, 2021

Adding new type of input for Monitors - HttpInput (#82)

f32409b

Closes #82

tlfeng pushed a commit that referenced this pull request Feb 6, 2021

Revert "Adding new type of input for Monitors - HttpInput (#82)" (#162)

cf5ef57

This reverts commit c2004f7.

tlfeng mentioned this pull request Feb 8, 2021

Add HTTP Input type for monitors (Inherited from PR #82) #347

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding HTTP Input type for monitors #82

Adding HTTP Input type for monitors #82

ann3431 commented Jul 16, 2019 •

edited

Loading

ghost left a comment

ann3431 commented Jul 19, 2019

ann3431 left a comment

ann3431 left a comment

Adding HTTP Input type for monitors #82

Adding HTTP Input type for monitors #82

Conversation

ann3431 commented Jul 16, 2019 • edited Loading

ghost left a comment

Choose a reason for hiding this comment

ann3431 commented Jul 19, 2019

ann3431 left a comment

Choose a reason for hiding this comment

ann3431 left a comment

Choose a reason for hiding this comment

ann3431 commented Jul 16, 2019 •

edited

Loading