resolve #58 return error response #72

seraphjiang · 2019-06-21T18:11:45Z

This is required api change to support quick fix for #58
There is another long term error exception handle enhancement in my plan. That cause more change is not part of this fix.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

this is required api change to support quick fix for opendistro-for-elasticsearch#58, there is another long term error exception handle enhancement in plan.

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt

this is required api change to support quick fix for opendistro-for-elasticsearch#58, there is another long term error exception handle enhancement in plan.

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt

seraphjiang · 2019-06-21T22:48:24Z

./gradlew :alerting:build

Configure project :alerting
=======================================
Elasticsearch Build Hamster says Hello!
Gradle Version : 5.2.1
OS Info : Mac OS X 10.13.6 (x86_64)
JDK Version : 12 (Oracle Corporation 12.0.1 [Java HotSpot(TM) 64-Bit Server VM 12.0.1+12])
JAVA_HOME : /Library/Java/JavaVirtualMachines/jdk-12.0.1.jdk/Contents/Home
Random Testing Seed : 14B11DF1003C6EB4
=======================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 1s
40 actionable tasks: 20 executed, 20 up-to-date

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt

mihirsoni

LGTM. Thanks for the changes.

qreshi

LGTM, thanks for the change!

…stro-for-elasticsearch#72) * resolve opendistro-for-elasticsearch#58 return error response this is required api change to support quick fix for opendistro-for-elasticsearch#58, there is another long term error exception handle enhancement in plan. * fix code formation issue to pass style check

* resolve #58 return error response this is required api change to support quick fix for #58, there is another long term error exception handle enhancement in plan. * fix code formation issue to pass style check

resolve opendistro-for-elasticsearch#58 return error response

c56e25f

this is required api change to support quick fix for opendistro-for-elasticsearch#58, there is another long term error exception handle enhancement in plan.

seraphjiang requested review from lucaswin-amzn, qreshi and ylwu-amzn June 21, 2019 18:12

qreshi reviewed Jun 21, 2019

View reviewed changes

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt Outdated Show resolved Hide resolved

seraphjiang added 2 commits June 21, 2019 13:43

resolve opendistro-for-elasticsearch#58 return error response

fcf2475

this is required api change to support quick fix for opendistro-for-elasticsearch#58, there is another long term error exception handle enhancement in plan.

Merge branch 'master' of github.com:seraphjiang/alerting

80f176c

seraphjiang commented Jun 21, 2019

View reviewed changes

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt Outdated Show resolved Hide resolved

fix code formation issue to pass style check

fed6f3f

qreshi reviewed Jun 21, 2019

View reviewed changes

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt Outdated Show resolved Hide resolved

mihirsoni reviewed Jun 22, 2019

View reviewed changes

...ing/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/model/MonitorRunResult.kt Outdated Show resolved Hide resolved

seraphjiang added 5 commits June 22, 2019 11:48

fix code formation issue to pass style check

15dbd14

Merge branch 'master' of github.com:seraphjiang/alerting

898775d

fix code formation issue to pass style check

e2948a9

fix code formation issue to pass style check

f3f7b12

erge branch 'master' of github.com:seraphjiang/alerting

fb8f42d

seraphjiang requested review from mihirsoni and qreshi June 22, 2019 19:13

mihirsoni approved these changes Jun 23, 2019

View reviewed changes

qreshi approved these changes Jun 24, 2019

View reviewed changes

seraphjiang merged commit 9c66731 into opendistro-for-elasticsearch:master Jun 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolve #58 return error response #72

resolve #58 return error response #72

seraphjiang commented Jun 21, 2019

seraphjiang commented Jun 21, 2019

mihirsoni left a comment

qreshi left a comment

resolve #58 return error response #72

resolve #58 return error response #72

Conversation

seraphjiang commented Jun 21, 2019

seraphjiang commented Jun 21, 2019

mihirsoni left a comment

Choose a reason for hiding this comment

qreshi left a comment

Choose a reason for hiding this comment