Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

configure action throttle max value in ES setting #69

Merged
merged 6 commits into from
Jun 18, 2019
Merged

configure action throttle max value in ES setting #69

merged 6 commits into from
Jun 18, 2019

Conversation

ylwu-amzn
Copy link
Contributor

configure action throttle max value in ES setting

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lucaswin-amzn
lucaswin-amzn suggested changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@lucaswin-amzn lucaswin-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Jinsoos comment, also please add API tests for invalid throttle values + changing the throttle value to ensure that the setting is actually updated.

jinsoor-amzn
jinsoor-amzn approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@jinsoor-amzn jinsoor-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the change!

@ylwu-amzn ylwu-amzn requested a review from lucaswin-amzn June 17, 2019 23:41
@ylwu-amzn
Copy link
Contributor Author

Starting a Gradle Daemon (subsequent builds will be faster)

Configure project :alerting
=======================================
Elasticsearch Build Hamster says Hello!
Gradle Version : 5.2.1
OS Info : Mac OS X 10.13.6 (x86_64)
JDK Version : 12 (Oracle Corporation 12 [Java HotSpot(TM) 64-Bit Server VM 12+33])
JAVA_HOME : /Library/Java/JavaVirtualMachines/jdk-12.jdk/Contents/Home
Random Testing Seed : 918EB3F52067FEA0
=======================================

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 3m 19s

lucaswin-amzn
lucaswin-amzn approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@lucaswin-amzn lucaswin-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the change

@ylwu-amzn ylwu-amzn merged commit 5ef6221 into opendistro-for-elasticsearch:master Jun 18, 2019
@ylwu-amzn ylwu-amzn deleted the throttle_limit branch June 18, 2019 17:26
ann3431 pushed a commit to ann3431/alerting that referenced this pull request Jul 16, 2019
@ylwu-amzn @ann3431
configure action throttle max value in ES setting (opendistro-for-ela…
d2acbf9 
…sticsearch#69)

* configure action throttle max value in ES setting
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
@ylwu-amzn
configure action throttle max value in ES setting (#69)
4195586 
* configure action throttle max value in ES setting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucaswin-amzn lucaswin-amzn lucaswin-amzn approved these changes

@jinsoor-amzn jinsoor-amzn jinsoor-amzn approved these changes

@dbbaughe dbbaughe Awaiting requested review from dbbaughe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ylwu-amzn @jinsoor-amzn @lucaswin-amzn