Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Throttle #59

Merged
merged 4 commits into from
May 21, 2019
Merged

Conversation

ylwu-amzn
Copy link
Contributor

1.Fix update action execution result bug;
2.Add integration test code change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ylwu-amzn ylwu-amzn requested review from dbbaughe and mihirsoni May 17, 2019 19:29
@dbbaughe
Copy link
Contributor

Unrelated to this specific PR, but:
Adding Throttling introduced an update to our mappings. We need to add "schema_version" to the mappings and set it to 1 with this update. And in the code if schema_version does not exist on the document we'll assume it's 0 (ie initial release/before throttling was added).

We also need to add a way to update the mappings on each cluster. Currently none of the index mappings will be updated since we only do that once on initial use of alerting.

All of this needs to happen ASAP before we cut a release for 7.0

@ylwu-amzn
Copy link
Contributor Author

ylwu-amzn commented May 20, 2019

Create a new issue to track the schema versioning. #60

Copy link
Contributor

@jinsoor-amzn jinsoor-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@ylwu-amzn ylwu-amzn merged commit 7ed67a2 into opendistro-for-elasticsearch:master May 21, 2019
@ylwu-amzn ylwu-amzn deleted the throttle branch May 23, 2019 16:23
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
fix action throttle update action execution result bug
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants