This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 80
Throttle #59
Merged
ylwu-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
ylwu-amzn:throttle
May 21, 2019
Merged
Throttle #59
ylwu-amzn
merged 4 commits into
opendistro-for-elasticsearch:master
from
ylwu-amzn:throttle
May 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsoni
reviewed
May 17, 2019
alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunnerIT.kt
Outdated
Show resolved
Hide resolved
alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunnerIT.kt
Outdated
Show resolved
Hide resolved
alerting/src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/MonitorRunnerIT.kt
Outdated
Show resolved
Hide resolved
Unrelated to this specific PR, but: We also need to add a way to update the mappings on each cluster. Currently none of the index mappings will be updated since we only do that once on initial use of alerting. All of this needs to happen ASAP before we cut a release for 7.0 |
Create a new issue to track the schema versioning. #60 |
jinsoor-amzn
approved these changes
May 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
mihirsoni
approved these changes
May 21, 2019
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
fix action throttle update action execution result bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Fix update action execution result bug;
2.Add integration test code change
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.