This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
validate all 2xx status code in Webhook response #49 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reststatus.Created for WebHook-Response is also acceptable (opendistro-for-elasticsearch#49).
|
Hi, Thank you for the PR. Can you please change so that it allows all of 2xx HTTP status code? |
using all 2XX response status as valid response
|
Hi, I just added all 2XX status codes as valid response. |
lucaswin-amzn
approved these changes
May 9, 2019
mihirsoni
changed the title
mihirsoni
approved these changes
May 9, 2019
vamshin
reviewed
May 10, 2019
| /** | ||
| * all valid response status | ||
| */ | ||
| private static final Set<Integer> VALID_RESPONSE_STATUS = new HashSet<>( |
There was a problem hiding this comment.
Np: Should we call SUCCESS_RESPONSE_STATUS? To me all the http codes are valid(1XX, 3XX, 4XX)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reststatus.Created for WebHook-Response is also acceptable (#49).
Issue #49:
Description of changes: Reststatus 201 is also acceptable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.