Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Adds support for ES 7.6.1 #186

Merged
merged 6 commits into from
Mar 26, 2020
Merged

Adds support for ES 7.6.1 #186

merged 6 commits into from
Mar 26, 2020

Conversation

ftianli-amzn
Copy link

Issue #, if available:
Closes #179

Description of changes:
Make Alerting plugin compatible with Elasticsearch 7.6.1.

  • Bump Elasticsearch version
  • Bump Gradle version
  • Bump nebula.ospackage version
  • Update the requirement of JDK 13 in README and workflow files
  • All the changes made to support ES7.5.2 from ES7.4.1, please refer to Adds support for Elasticsearch 7.5.2 #185

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dbbaughe
dbbaughe reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please update the release notes

gradle/wrapper/gradle-wrapper.properties Show resolved Hide resolved
@ftianli-amzn
Copy link
Author

Also please update the release notes

Thank you for reminding me.

@dbbaughe dbbaughe changed the title Opendistro 1.6 Adds support for ES 7.6.1 Mar 26, 2020
@dbbaughe
Copy link
Contributor

@qreshi Is the github workflow stuck expecting the old Build Alerting with JDK 12 because it was changed in this PR to be the 13 one that passed?

@qreshi
Copy link
Contributor

qreshi commented Mar 26, 2020

@qreshi Is the github workflow stuck expecting the old Build Alerting with JDK 12 because it was changed in this PR to be the 13 one that passed?

Yeah, it looks like because we have Build Alerting with JDK 12 as a required status check it runs on every revision on a PR but changing to JDK 13 registers as a new check and it can't run the old one since we changed it. I'll disable the JDK 12 check as a requirement on master so we can merge this in and then switch it over to the JDK 13 one.

@ftianli-amzn
Copy link
Author

Do we need at least 2 reviewers in the PR? Unfortunately, I don't have the permission to request reviewers

@dbbaughe dbbaughe merged commit b274468 into opendistro-for-elasticsearch:master Mar 26, 2020
tlfeng pushed a commit that referenced this pull request Feb 6, 2021
Adds support for ES 7.6.1 (#186)
737289d 
* Upgrade Gradle to 6.2.2

* Adds support for Elasticsearch 7.6.1

* Update the requirement of JDK 13 in README and workflow files

* Upgrade Gradle to 6.2.2 correctly

* Update release notes

* Update release notes: remove a useless feature note
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@qreshi qreshi qreshi approved these changes

@dbbaughe dbbaughe dbbaughe approved these changes

@jinsoor-amzn jinsoor-amzn Awaiting requested review from jinsoor-amzn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elasticsearch 7.6.1 compatibility
3 participants
@ftianli-amzn @dbbaughe @qreshi