This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adds settings to disable and delete history #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/alerts/AlertIndices.kt
Show resolved
Hide resolved
alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/alerts/AlertIndices.kt
Show resolved
Hide resolved
lucaswin-amzn
previously approved these changes
Jan 9, 2020
dbbaughe
reviewed
Jan 13, 2020
alerting/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/alerts/AlertIndices.kt
Outdated
Show resolved
Hide resolved
…allow for recreation when history is reenabled
… the history write index
dbbaughe
approved these changes
Jan 14, 2020
mihirsoni
approved these changes
Jan 14, 2020
tlfeng
pushed a commit
that referenced
this pull request
Feb 6, 2021
* Added retention period and disable alert history settings * Added logic to delete old history indices * Added integration tests for disabling history and history retention * Reset historyIndexInitialized when history write index is deleted to allow for recreation when history is reenabled * Fix bug where other history indices aren't deleted after iterating on the history write index
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds settings for disabling alert history and deleting old history indices.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.