Don't allow interval to be set with 0 or negative values. (#92)

opendistro-for-elasticsearch · Aug 13, 2019 · d3e29a6 · d3e29a6
1 parent ec9292d
commit d3e29a6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/Schedule.kt b/core/src/main/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/Schedule.kt
@@ -249,6 +249,10 @@ data class IntervalSchedule(
         if (!SUPPORTED_UNIT.contains(unit)) {
             throw IllegalArgumentException("Timezone $unit is not supported expected $SUPPORTED_UNIT")
         }
+
+        if (interval <= 0) {
+            throw IllegalArgumentException("Interval is not allowed to be 0 or negative")
+        }
     }
 
     @Transient

diff --git a/...src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/ScheduleTest.kt b/...src/test/kotlin/com/amazon/opendistroforelasticsearch/alerting/core/model/ScheduleTest.kt
@@ -336,5 +336,9 @@ class ScheduleTest : XContentTestBase {
         assertFailsWith(IllegalArgumentException::class, "Expected IllegalArgumentException") {
             IntervalSchedule(1, ChronoUnit.MONTHS)
         }
+
+        assertFailsWith(IllegalArgumentException::class, "Expected IllegalArgumentException") {
+            IntervalSchedule(-1, ChronoUnit.MINUTES)
+        }
     }
 }