This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix invalid value for new parameters and headers on Custom Destination #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the changes @ricardobessa1 , just one small nitpick, I think we use single quotes in this project. I believe prettier is set up though to run before each commit, so not sure why that didn't make those changes. |
@dbbaughe thanks for feedback, I ll check why it not run before commit and send the changes. |
ylwu-amzn
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #71
Description of changes:
Change the empty object {} to { key: "", value: "" } when push new parameters and headers on form.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.