This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix update monitor from moniotr list #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbaughe
reviewed
Jun 26, 2019
| @@ -180,9 +180,12 @@ export default class Monitors extends Component { | |||
|
|
|||
| updateMonitor(item, update) { | |||
| const { httpClient } = this.props; | |||
| const { id, version, monitor } = item; | |||
There was a problem hiding this comment.
Let's call them seqNo and primaryTerm, the ifSeqNo/ifPrimaryTerm is just for the API query term. The actual values represent seqNo and primaryTerm.
There was a problem hiding this comment.
Sure. Will fix it part of next PR. This is how currently it is being used rest of the place. Will change it together.
dbbaughe
approved these changes
Jun 26, 2019
mihirsoni
added a commit
that referenced
this pull request
Jun 26, 2019
Pass seqNo and PrimaryTerm for updateMonitor API.
mihirsoni
added a commit
that referenced
this pull request
Jun 26, 2019
Pass seqNo and PrimaryTerm for updateMonitor API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable / Disable breaks from Monitor list.
Description of changes: Pass SeqNo and PrimaryTerm from actions.
Need port back to 1.0 branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.