Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Update placeholder text for whereFilter #54

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Update placeholder text for whereFilter #54

merged 3 commits into from
Jun 11, 2019

Conversation

mihirsoni
Copy link
Contributor

@mihirsoni mihirsoni commented Jun 10, 2019

Update text placeholder for Where filter inside visual Graph to be more aligned with visual monitor sentence.

Fixed other broken snapshots.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

aetter
aetter previously approved these changes Jun 10, 2019
dbbaughe
dbbaughe previously approved these changes Jun 11, 2019
@mihirsoni mihirsoni dismissed stale reviews from dbbaughe and aetter via e442ff7 June 11, 2019 17:49
@dbbaughe
Copy link
Contributor

Do we have specific sections we can link them to that keeps the context of the help link rather than the main alerting page?

@aetter aetter self-requested a review June 11, 2019 18:08
@aetter
Copy link
Contributor

aetter commented Jun 11, 2019

Hi @dbbaughe, sure, we'd just need to add some variables. The same URL.DOCUMENTATION link gets reused for Query performance and Custom cron expressions at present, so I went with the main page.

@dbbaughe
Copy link
Contributor

Ok, will create an issue to link to more specific documentation

@mihirsoni mihirsoni merged commit fbc1eb2 into opendistro-for-elasticsearch:master Jun 11, 2019
@mihirsoni mihirsoni deleted the mihirsoni-patch-1 branch June 11, 2019 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants