This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
add throttle on action level #45
Merged
ylwu-amzn
merged 11 commits into
opendistro-for-elasticsearch:master
from
ylwu-amzn:throttle
May 14, 2019
Merged
add throttle on action level #45
ylwu-amzn
merged 11 commits into
opendistro-for-elasticsearch:master
from
ylwu-amzn:throttle
May 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsoni
suggested changes
May 10, 2019
public/pages/CreateTrigger/components/Action/actions/Message.js
Outdated
Show resolved
Hide resolved
public/pages/CreateTrigger/components/Action/actions/Message.js
Outdated
Show resolved
Hide resolved
public/pages/CreateTrigger/components/Action/actions/Message.js
Outdated
Show resolved
Hide resolved
public/pages/CreateTrigger/components/Action/actions/Message.js
Outdated
Show resolved
Hide resolved
mihirsoni
previously approved these changes
May 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for the changes.
dbbaughe
reviewed
May 10, 2019
public/pages/CreateTrigger/components/Action/actions/Message.js
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
May 13, 2019
mihirsoni
reviewed
May 13, 2019
…ottle value input
mihirsoni
reviewed
May 14, 2019
public/components/FormControls/FormikFieldNumber/FormikFieldNumber.js
Outdated
Show resolved
Hide resolved
mihirsoni
previously approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for changes.
dbbaughe
reviewed
May 14, 2019
dbbaughe
approved these changes
May 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Yaliang!
mihirsoni
approved these changes
May 14, 2019
Hey guys this is amazin' Just curious, how often do you release? Can we make a release for this soon, and once released, what does it take to get it into AWS elasticsearch?? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue opendistro-for-elasticsearch/alerting#14:
Add throttle on action level.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.