Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

where clause support for Visual Monitor #42

Merged
merged 3 commits into from
May 7, 2019
Merged

where clause support for Visual Monitor #42

merged 3 commits into from
May 7, 2019

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #23

Description of changes:

This PR enables support for adding single where filter for creating monitor using visual graph.

Supported filters , datatypes

Operator dataTypes
is number,text,keyword,boolean
is not number,text,keyword,boolean
is null number,text,keyword,boolean
is not null number,text,keyword
is grater than number
is grater than equal number
is less than number
is less than equal number
is in range number
is not in range number
starts with text,keyword
ends with text,keyword
contains text,keyword
does not contains text

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mihirsoni mihirsoni requested a review from dbbaughe May 3, 2019 22:37
@mihirsoni mihirsoni changed the title 5Initial where clause UI Initial where clause UI May 3, 2019
@mihirsoni mihirsoni changed the title Initial where clause UI where clause support for Visual Graph May 3, 2019
@mihirsoni mihirsoni changed the title where clause support for Visual Graph where clause support for Visual Monitor May 3, 2019
dbbaughe
dbbaughe previously approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Mihir

@mihirsoni mihirsoni requested a review from ylwu-amzn May 7, 2019 17:44
@mihirsoni mihirsoni requested a review from dbbaughe May 7, 2019 18:53
ylwu-amzn
ylwu-amzn approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ylwu-amzn ylwu-amzn self-requested a review May 7, 2019 18:58
@mihirsoni mihirsoni merged commit 6668b59 into opendistro-for-elasticsearch:master May 7, 2019
@mihirsoni mihirsoni deleted the issue-23 branch May 7, 2019 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ylwu-amzn ylwu-amzn ylwu-amzn approved these changes

@dbbaughe dbbaughe dbbaughe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihirsoni @dbbaughe @ylwu-amzn