This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Replace all 'render' props to 'children' props in Formik elements #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
With the Formik v2.x upgrade (#236), there is a new deprecation warning shows in the browser console (for screenshot see the PR above).
The solution is to replace all the usage of
render
props tochildren props
in<Field>, <FastField>, <Formik>,<FieldArray>
elements, according to the official guide: https://formik.org/docs/migrating-v2#deprecation-warningsDescription of changes:
<Formik> <Field> <FieldArray>
elementsNote:
The
children
props can be used implicitly without statingchildren=
(https://reactjs.org/docs/render-props.html#using-props-other-than-render)In Enzyme's
mount()
method,children
props can't be put directly inside the element, so I statechildren=
explicitly in the specific unit tests.Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.