Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Change the query parameters 'size' and 'search' of 'getDestinations' request to be optional #231

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

ftianli-amzn
Copy link

@ftianli-amzn ftianli-amzn commented Jan 6, 2021

Issue #, if available:

Description of changes:

This is a mistake made during the migration to new Kibana platform (PR #209)

Current behavior:
Destinations list fails to refresh after removing a destination.

Reason:
The route validation for the front-end getDestinations request is not correct.
No query parameters comes with the request when getting the destinations list after removing a destination.

  • Change the query parameters 'size' and 'search' of 'getDestinations' request to be optional in the router.

Snipaste_2021-01-05_22-30-13 getDestinations api when remove dest

After the change, destinations list can be refreshed after removing a destination.

Test Suites: 6 skipped, 83 passed, 83 of 89 total
Tests:       20 skipped, 385 passed, 405 total
Snapshots:   135 passed, 135 total
Time:        61.738 s
Ran all test suites.
✨  Done in 62.99s.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ftianli-amzn ftianli-amzn changed the title Change the query parameters 'from' and 'size' in 'getDestinations' API to be optional Change the query parameters 'size' and 'search' in 'getDestinations' API to be optional Jan 6, 2021
@ftianli-amzn ftianli-amzn changed the title Change the query parameters 'size' and 'search' in 'getDestinations' API to be optional Change the query parameters 'size' and 'search' of 'getDestinations' API to be optional Jan 6, 2021
@ftianli-amzn ftianli-amzn added the bug Something isn't working label Jan 6, 2021
@ftianli-amzn ftianli-amzn changed the title Change the query parameters 'size' and 'search' of 'getDestinations' API to be optional Change the query parameters 'size' and 'search' of 'getDestinations' request to be optional Jan 6, 2021
@ftianli-amzn ftianli-amzn merged commit f505177 into opendistro-for-elasticsearch:master Jan 6, 2021
@ftianli-amzn ftianli-amzn deleted the getDestinations-api-validate branch January 6, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants