This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
Adds support for Kibana 7.9.0 #171
Merged
bowenlan-amzn
merged 3 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:od-1.10.0
Aug 24, 2020
Merged
Adds support for Kibana 7.9.0 #171
bowenlan-amzn
merged 3 commits into
opendistro-for-elasticsearch:master
from
bowenlan-amzn:od-1.10.0
Aug 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenlan-amzn
requested review from
dbbaughe,
ylwu-amzn and
ftianli-amzn
and removed request for
dbbaughe
August 24, 2020 21:49
dbbaughe
reviewed
Aug 24, 2020
public/pages/CreateMonitor/containers/AnomalyDetectors/__tests__/AnomalyDetector.test.js
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Aug 24, 2020
Test Suites: 6 skipped, 78 passed, 78 of 84 total |
I think the release note file is missing for 1.10.0.0 Edit: Bowen mentioned he's doing release notes in follow up PR |
dbbaughe
approved these changes
Aug 24, 2020
ftianli-amzn
approved these changes
Aug 24, 2020
ftianli-amzn
added a commit
that referenced
this pull request
Aug 25, 2020
* Adds support for Kibana 7.8.0 (#163) * Bump version number of ES, ODFE, and node * update Jest snapshots * update release notes with Kibana 7.8.0 support * Move plugin entry into Kibana app category in sidebar (cherry picked from commit bf9a91c) * Update the unit-test workflow script to get Kibana version from package.json (#165) * Get Kibana version from the package.json file in unit-test workflow (cherry picked from commit 6d82e56) * Fix the unit-test workflow by checking out the repo first (cherry picked from commit cc9fc0c) * Bump lodash from 4.17.15 to 4.17.19 (#169) * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * update yarn.lock by running 'yarn kbn bootstrap' Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tianli Feng <[email protected]> (cherry picked from commit 8b0dd58) * Adds support for Kibana 7.9.0 (#171) * keyCode to key * fix UT * remove used dependency (cherry picked from commit 5d3ff53) * Release note automate (#172) * release note automation * python script fix * compatibale with Kibana (cherry picked from commit c72d37e) * upgrade cypress verison to 5.0.0 * ingonre an uncaught error and add some copyright notice * change a wording back Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bowen Lan <[email protected]>
ftianli-amzn
added a commit
that referenced
this pull request
Aug 25, 2020
* Adds support for Kibana 7.8.0 (#163) * Bump version number of ES, ODFE, and node * update Jest snapshots * update release notes with Kibana 7.8.0 support * Move plugin entry into Kibana app category in sidebar (cherry picked from commit bf9a91c) * Update the unit-test workflow script to get Kibana version from package.json (#165) * Get Kibana version from the package.json file in unit-test workflow (cherry picked from commit 6d82e56) * Fix the unit-test workflow by checking out the repo first (cherry picked from commit cc9fc0c) * Bump lodash from 4.17.15 to 4.17.19 (#169) * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <[email protected]> * update yarn.lock by running 'yarn kbn bootstrap' Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tianli Feng <[email protected]> (cherry picked from commit 8b0dd58) * Adds support for Kibana 7.9.0 (#171) * keyCode to key * fix UT * remove used dependency (cherry picked from commit 5d3ff53) * Release note automate (#172) * release note automation * python script fix * compatibale with Kibana (cherry picked from commit c72d37e) * upgrade cypress verison to 5.0.0 * ingonre an uncaught error and add some copyright notice * change a wording back Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bowen Lan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Some UTs failed:
{key: 'Enter'}
can fix thisMonitors.js getActiveAlerts()
method,alerts
in the response is undefined which failed 2 tests belowwe need to mock the response in the previous UT to fix this
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.