-
Notifications
You must be signed in to change notification settings - Fork 62
Adds support for Kibana 7.7.0 #151
Adds support for Kibana 7.7.0 #151
Conversation
public/pages/CreateMonitor/components/AnomalyDetectors/AnomaliesChart/AnomaliesChart.js
Show resolved
Hide resolved
|
Did you run into any Kibana icon styling issue? I believe other teams were running in to that. |
😳 I haven't started a Kibana server to test yet, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for catching this hidden issue! 👏 |
Test Suites: 6 skipped, 78 passed, 78 of 84 total |
@ftianli-amzn tested on latest Ubuntu image (created ~6 hours ago), error is still there. Did you push new artifacts last night? |
Ah, sorry I didn't push the artifacts yet.. |
no problem. will check tomorrow |
Have uploaded, hope there will be a new docker image created earlier. |
Thank you for testing the plugin, Tyler! I noticed there were remaining |
@ylwu-amzn Were there tests written for this component? Wouldn't a simple snapshot test catch this not being able to render? |
I will do a manually test for this feature today in case there are other exceptions thrown. |
Thank you all for taking look at this PR, I will merge it shortly. |
Good suggestion. We should add more test cased for AD components. Created an issue #156. |
Thank you for opening an issue! Nice |
Issue #, if available:
#150
Description of changes:
package.json
package.json
getAxisId
,getSpecId
, andgetAnnotationId
getters fromElastic Charts
module (feat: expose Specs types and clean up annotation types elastic/elastic-charts#554)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.