Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

change words and padding according to ux review comments #132

Merged
merged 2 commits into from
Apr 29, 2020
Merged

change words and padding according to ux review comments #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0aaac
change words and padding according to ux review comments
ylwu-amzn Apr 29, 2020
4bf0f4e
fix padding of monitor schedule
ylwu-amzn Apr 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/pages/CreateMonitor/components/MonitorDefinition/MonitorDefinition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@ const onChangeDefinition = (e, form, resetResponse) => {
const selectDefinitions = plugins => {
return plugins === undefined || plugins.indexOf(ES_AD_PLUGIN) == -1
? defaultSelectDefinitions
: [...defaultSelectDefinitions, { value: 'ad', text: 'Define using Anomaly detector' }];
: [...defaultSelectDefinitions, { value: 'ad', text: 'Define using anomaly detector' }];
};

const MonitorDefinition = ({ resetResponse, plugins }) => (
<FormikSelect
name="searchType"
formRow
rowProps={{
label: 'How do you want to define the monitor?',
label: 'Define the monitor',
style: { paddingLeft: '10px' },
}}
inputProps={{
Expand Down
2 changes: 1 addition & 1 deletion ...s/CreateMonitor/components/MonitorDefinition/__snapshots__/MonitorDefinition.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ exports[`MonitorDefinition renders 1`] = `
class="euiFormLabel euiFormRow__label"
for="searchType-form-row"
>
How do you want to define the monitor?
Define the monitor
</label>
</div>
<div
Expand Down
2 changes: 1 addition & 1 deletion public/pages/CreateMonitor/components/Schedule/Frequencies/Interval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const Interval = () => (
inputProps={{ icon: 'clock', min: 1 }}
/>
</EuiFlexItem>
<EuiFlexItem style={{ margin: '0px' }}>
<EuiFlexItem style={{ margin: '2px' }}>
<FormikSelect
name="period.unit"
formRow
Expand Down
4 changes: 2 additions & 2 deletions ...ages/CreateMonitor/components/Schedule/Frequencies/__snapshots__/Frequencies.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ exports[`Frequencies renders FrequencyPicker 1`] = `
</div>
<div
class="euiFlexItem"
style="margin:0px"
style="margin:2px"
>
<div
class="euiFormRow euiFormRow--hasEmptyLabelSpace"
Expand Down Expand Up @@ -379,7 +379,7 @@ exports[`Frequencies renders Interval 1`] = `
</div>
<div
class="euiFlexItem"
style="margin:0px"
style="margin:2px"
>
<div
class="euiFormRow euiFormRow--hasEmptyLabelSpace"
Expand Down
6 changes: 5 additions & 1 deletion public/pages/CreateMonitor/containers/AnomalyDetectors/AnomalyDetectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ class AnomalyDetectors extends React.Component {
}
}
return (
<div>
<div
style={{
maxWidth: '390px',
}}
>
<FormikComboBox
name={'detectorId'}
formRow
Expand Down
8 changes: 7 additions & 1 deletion ...eMonitor/containers/AnomalyDetectors/__tests__/__snapshots__/AnomalyDetector.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,13 @@ exports[`AnomalyDetectors renders 1`] = `
}
}
>
<div>
<div
style={
Object {
"maxWidth": "390px",
}
}
>
<FormikComboBox
fieldProps={
Object {
Expand Down
4 changes: 2 additions & 2 deletions public/pages/CreateTrigger/containers/DefineTrigger/AnomalyDetectorTrigger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class AnomalyDetectorTrigger extends React.Component {
thresholdEnum={adValues.anomalyGradeThresholdEnum}
keyFieldName="anomalyDetector.anomalyGradeThresholdEnum"
valueFieldName="anomalyDetector.anomalyGradeThresholdValue"
label="Anomaly grade condition"
label="Anomaly grade threshold"
/>
<EuiSpacer size="xs" />
<AnomaliesChart
Expand All @@ -77,7 +77,7 @@ class AnomalyDetectorTrigger extends React.Component {
thresholdEnum={adValues.anomalyConfidenceThresholdEnum}
keyFieldName="anomalyDetector.anomalyConfidenceThresholdEnum"
valueFieldName="anomalyDetector.anomalyConfidenceThresholdValue"
label="Anomaly confidence condition"
label="Anomaly confidence threshold"
/>
<EuiSpacer size="xs" />
<AnomaliesChart
Expand Down
3 changes: 1 addition & 2 deletions public/pages/MonitorDetails/containers/MonitorDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,7 @@ export default class MonitorDetails extends Component {
external="true"
target="_blank"
>
{detector.name}
<EuiIcon size="s" type="popout" />
{detector.name} <EuiIcon size="s" type="popout" />
</EuiLink>
</EuiText>
</EuiFlexItem>
Expand Down