opendistro-for-elasticsearch · qreshi · Nov 21, 2019 · Nov 21, 2019 · Nov 21, 2019 · Nov 21, 2019
diff --git a/opendistro-elasticsearch-alerting-kibana.release-notes.md b/opendistro-elasticsearch-alerting-kibana.release-notes.md
@@ -1,9 +1,14 @@
-## Version 1.2.0.0
+## Version 1.3.0.0
 
-## New Features
-  * Adds support for Kibana 7.2.0
+### New Features
+  * Adds support for Kibana 7.3.2 - [PR #109](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/109)
+
+## 2019-09-20, Version 1.2.0.0
 
-## Bug fixes
+### New Features
+  * Adds support for Kibana 7.2.0 - [PR #81](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/81)
+
+### Bug fixes
   * Fixes update monitor from monitor list - [PR #64](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/64)
   * Added support for IPv4 and IPv6 on URL validation - [PR #67](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/67)
   * Disables the query parameter box in Custom webhook - [PR #72](https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/pull/72)

diff --git a/package.json b/package.json
@@ -1,12 +1,12 @@
 {
   "name": "opendistro-alerting",
-  "version": "1.2.0.0",
+  "version": "1.3.0.0",
   "description": "Kibana Alerting Plugin",
   "main": "index.js",
   "license": "Apache-2.0",
   "homepage": "https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin",
   "kibana": {
-    "version": "7.2.0",
+    "version": "7.3.2",
     "templateVersion": "6.3.3"
   },
   "repository": {

diff --git a/...omponents/FormControls/FormikFieldPassword/__snapshots__/FormikFieldPassword.test.js.snap b/...omponents/FormControls/FormikFieldPassword/__snapshots__/FormikFieldPassword.test.js.snap
@@ -20,17 +20,13 @@ exports[`FormikFieldPassword renders 1`] = `
       >
         <svg
           aria-hidden="true"
-          class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+          class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
           focusable="false"
           height="16"
           viewBox="0 0 16 16"
           width="16"
           xmlns="http://www.w3.org/2000/svg"
-        >
-          <path
-            d="M4 5v-.8C4 1.88 5.79 0 8 0s4 1.88 4 4.2V5h1.143c.473 0 .857.448.857 1v9c0 .552-.384 1-.857 1H2.857C2.384 16 2 15.552 2 15V6c0-.552.384-1 .857-1H4zM3 15h10V6H3v9zm5.998-3.706L9.5 12.5h-3l.502-1.206A1.644 1.644 0 0 1 6.5 10.1c0-.883.672-1.6 1.5-1.6s1.5.717 1.5 1.6c0 .475-.194.901-.502 1.194zM11 4.36C11 2.504 9.657 1 8 1S5 2.504 5 4.36V5h6v-.64z"
-          />
-        </svg>
+        />
       </span>
     </div>
   </div>

diff --git a/public/components/FormControls/FormikSelect/__snapshots__/FormikSelect.test.js.snap b/public/components/FormControls/FormikSelect/__snapshots__/FormikSelect.test.js.snap
@@ -26,25 +26,13 @@ exports[`FormikSelect renders 1`] = `
       >
         <svg
           aria-hidden="true"
-          class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+          class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
           focusable="false"
           height="16"
           viewBox="0 0 16 16"
           width="16"
-          xlink="http://www.w3.org/1999/xlink"
           xmlns="http://www.w3.org/2000/svg"
-        >
-          <defs>
-            <path
-              d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-              id="arrow_down-a"
-            />
-          </defs>
-          <use
-            fill-rule="nonzero"
-            href="#arrow_down-a"
-          />
-        </svg>
+        />
       </span>
     </div>
   </div>

diff --git a/public/components/FormControls/FormikSwitch/__snapshots__/FormikSwitch.test.js.snap b/public/components/FormControls/FormikSwitch/__snapshots__/FormikSwitch.test.js.snap
@@ -20,30 +20,21 @@ exports[`FormikSwitch renders 1`] = `
       class="euiSwitch__track"
     >
       <svg
-        class="euiIcon euiIcon--medium euiSwitch__icon"
+        class="euiIcon euiIcon--medium euiIcon-isLoading euiSwitch__icon"
         focusable="false"
         height="16"
         viewBox="0 0 16 16"
         width="16"
         xmlns="http://www.w3.org/2000/svg"
-      >
-        <path
-          d="M7.293 8L3.146 3.854a.5.5 0 1 1 .708-.708L8 7.293l4.146-4.147a.5.5 0 0 1 .708.708L8.707 8l4.147 4.146a.5.5 0 0 1-.708.708L8 8.707l-4.146 4.147a.5.5 0 0 1-.708-.708L7.293 8z"
-        />
-      </svg>
+      />
       <svg
-        class="euiIcon euiIcon--medium euiSwitch__icon euiSwitch__icon--checked"
+        class="euiIcon euiIcon--medium euiIcon-isLoading euiSwitch__icon euiSwitch__icon--checked"
         focusable="false"
         height="16"
         viewBox="0 0 16 16"
         width="16"
         xmlns="http://www.w3.org/2000/svg"
-      >
-        <path
-          d="M6.5 12a.502.502 0 0 1-.354-.146l-4-4a.502.502 0 0 1 .708-.708L6.5 10.793l6.646-6.647a.502.502 0 0 1 .708.708l-7 7A.502.502 0 0 1 6.5 12"
-          fill-rule="evenodd"
-        />
-      </svg>
+      />
     </span>
   </span>
 </div>

diff --git a/...s/CreateMonitor/components/MonitorDefinition/__snapshots__/MonitorDefinition.test.js.snap b/...s/CreateMonitor/components/MonitorDefinition/__snapshots__/MonitorDefinition.test.js.snap
@@ -44,25 +44,13 @@ exports[`MonitorDefinition renders 1`] = `
         >
           <svg
             aria-hidden="true"
-            class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+            class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
             focusable="false"
             height="16"
             viewBox="0 0 16 16"
             width="16"
-            xlink="http://www.w3.org/1999/xlink"
             xmlns="http://www.w3.org/2000/svg"
-          >
-            <defs>
-              <path
-                d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-                id="arrow_down-a"
-              />
-            </defs>
-            <use
-              fill-rule="nonzero"
-              href="#arrow_down-a"
-            />
-          </svg>
+          />
         </span>
       </div>
     </div>

diff --git a/public/pages/CreateMonitor/components/MonitorExpressions/expressions/WhereExpression.test.js b/public/pages/CreateMonitor/components/MonitorExpressions/expressions/WhereExpression.test.js
@@ -69,7 +69,7 @@ describe('WhereExpression', () => {
     button.simulate('keyDown', { keyCode: 27 });
     expect(closeExpression).toHaveBeenCalled();
   });
-  test('should render text input for the text data types', done => {
+  test('should render text input for the text data types', () => {
     const wrapper = mount(getMountWrapper(true));
     wrapper
       .find('[data-test-subj="comboBoxSearchInput"]')
@@ -78,14 +78,12 @@ describe('WhereExpression', () => {
       .simulate('keyDown', { keyCode: 40 })
       .simulate('keyDown', { keyCode: 13 })
       .simulate('blur');
-    setTimeout(() => {
-      wrapper.update();
-      const values = wrapper.find(WhereExpression).props().formik.values;
-      expect(values.where.fieldName).toEqual([{ label: 'cityName', type: 'text' }]);
-      expect(values.where.operator).toEqual(OPERATORS_MAP.IS);
-      expect(wrapper.find(FormikFieldText).length).toBe(1);
-      expect(wrapper.find(FormikFieldNumber).length).toBe(0);
-      done();
-    });
+
+    wrapper.update();
+    const values = wrapper.find(WhereExpression).props().formik.values;
+    expect(values.where.fieldName).toEqual([{ label: 'cityName', type: 'text' }]);
+    expect(values.where.operator).toEqual(OPERATORS_MAP.IS);
+    expect(wrapper.find(FormikFieldText).length).toBe(1);
+    expect(wrapper.find(FormikFieldNumber).length).toBe(0);
   });
 });
diff --git a/...ages/CreateMonitor/components/Schedule/Frequencies/__snapshots__/Frequencies.test.js.snap b/...ages/CreateMonitor/components/Schedule/Frequencies/__snapshots__/Frequencies.test.js.snap
@@ -111,25 +111,13 @@ exports[`Frequencies renders CustomCron 1`] = `
               >
                 <svg
                   aria-hidden="true"
-                  class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+                  class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                   focusable="false"
                   height="16"
                   viewBox="0 0 16 16"
                   width="16"
-                  xlink="http://www.w3.org/1999/xlink"
                   xmlns="http://www.w3.org/2000/svg"
-                >
-                  <defs>
-                    <path
-                      d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-                      id="arrow_down-a"
-                    />
-                  </defs>
-                  <use
-                    fill-rule="nonzero"
-                    href="#arrow_down-a"
-                  />
-                </svg>
+                />
               </button>
             </div>
           </div>
@@ -201,25 +189,13 @@ exports[`Frequencies renders Frequency 1`] = `
         >
           <svg
             aria-hidden="true"
-            class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+            class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
             focusable="false"
             height="16"
             viewBox="0 0 16 16"
             width="16"
-            xlink="http://www.w3.org/1999/xlink"
             xmlns="http://www.w3.org/2000/svg"
-          >
-            <defs>
-              <path
-                d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-                id="arrow_down-a"
-              />
-            </defs>
-            <use
-              fill-rule="nonzero"
-              href="#arrow_down-a"
-            />
-          </svg>
+          />
         </span>
       </div>
     </div>
@@ -270,18 +246,13 @@ exports[`Frequencies renders FrequencyPicker 1`] = `
             >
               <svg
                 aria-hidden="true"
-                class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+                class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                 focusable="false"
                 height="16"
                 viewBox="0 0 16 16"
                 width="16"
                 xmlns="http://www.w3.org/2000/svg"
-              >
-                <path
-                  d="M7.5 13A5.506 5.506 0 0 1 2 7.5C2 4.467 4.467 2 7.5 2S13 4.467 13 7.5 10.533 13 7.5 13m0-12a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13m3 6H8V3.5a.5.5 0 0 0-1 0v4a.5.5 0 0 0 .5.5h3a.5.5 0 0 0 0-1"
-                  fill-rule="evenodd"
-                />
-              </svg>
+              />
             </span>
           </div>
         </div>
@@ -332,25 +303,13 @@ exports[`Frequencies renders FrequencyPicker 1`] = `
             >
               <svg
                 aria-hidden="true"
-                class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+                class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                 focusable="false"
                 height="16"
                 viewBox="0 0 16 16"
                 width="16"
-                xlink="http://www.w3.org/1999/xlink"
                 xmlns="http://www.w3.org/2000/svg"
-              >
-                <defs>
-                  <path
-                    d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-                    id="arrow_down-a"
-                  />
-                </defs>
-                <use
-                  fill-rule="nonzero"
-                  href="#arrow_down-a"
-                />
-              </svg>
+              />
             </span>
           </div>
         </div>
@@ -403,18 +362,13 @@ exports[`Frequencies renders Interval 1`] = `
             >
               <svg
                 aria-hidden="true"
-                class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+                class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                 focusable="false"
                 height="16"
                 viewBox="0 0 16 16"
                 width="16"
                 xmlns="http://www.w3.org/2000/svg"
-              >
-                <path
-                  d="M7.5 13A5.506 5.506 0 0 1 2 7.5C2 4.467 4.467 2 7.5 2S13 4.467 13 7.5 10.533 13 7.5 13m0-12a6.5 6.5 0 1 0 0 13 6.5 6.5 0 0 0 0-13m3 6H8V3.5a.5.5 0 0 0-1 0v4a.5.5 0 0 0 .5.5h3a.5.5 0 0 0 0-1"
-                  fill-rule="evenodd"
-                />
-              </svg>
+              />
             </span>
           </div>
         </div>
@@ -465,25 +419,13 @@ exports[`Frequencies renders Interval 1`] = `
             >
               <svg
                 aria-hidden="true"
-                class="euiIcon euiIcon--medium euiFormControlLayoutCustomIcon__icon"
+                class="euiIcon euiIcon--medium euiIcon-isLoading euiFormControlLayoutCustomIcon__icon"
                 focusable="false"
                 height="16"
                 viewBox="0 0 16 16"
                 width="16"
-                xlink="http://www.w3.org/1999/xlink"
                 xmlns="http://www.w3.org/2000/svg"
-              >
-                <defs>
-                  <path
-                    d="M13.069 5.157L8.384 9.768a.546.546 0 0 1-.768 0L2.93 5.158a.552.552 0 0 0-.771 0 .53.53 0 0 0 0 .759l4.684 4.61c.641.631 1.672.63 2.312 0l4.684-4.61a.53.53 0 0 0 0-.76.552.552 0 0 0-.771 0z"
-                    id="arrow_down-a"
-                  />
-                </defs>
-                <use
-                  fill-rule="nonzero"
-                  href="#arrow_down-a"
-                />
-              </svg>
+              />
             </span>
           </div>
         </div>

diff --git a/public/pages/CreateMonitor/containers/CreateMonitor/__snapshots__/CreateMonitor.test.js.snap b/public/pages/CreateMonitor/containers/CreateMonitor/__snapshots__/CreateMonitor.test.js.snap
@@ -55,7 +55,7 @@ exports[`CreateMonitor renders 1`] = `
           "fieldName": Array [],
           "fieldRangeEnd": 0,
           "fieldRangeStart": 0,
-          "fieldValue": 0,
+          "fieldValue": "",
           "operator": "is",
         },
       }

diff --git a/...s/CreateMonitor/containers/CreateMonitor/utils/__snapshots__/formikToMonitor.test.js.snap b/...s/CreateMonitor/containers/CreateMonitor/utils/__snapshots__/formikToMonitor.test.js.snap
@@ -208,7 +208,7 @@ Object {
     "fieldName": Array [],
     "fieldRangeEnd": 0,
     "fieldRangeStart": 0,
-    "fieldValue": 0,
+    "fieldValue": "",
     "operator": "is",
   },
 }

diff --git a/public/pages/CreateMonitor/containers/CreateMonitor/utils/constants.js b/public/pages/CreateMonitor/containers/CreateMonitor/utils/constants.js
@@ -46,7 +46,7 @@ export const FORMIK_INITIAL_VALUES = {
   where: {
     fieldName: [],
     operator: OPERATORS_MAP.IS,
-    fieldValue: 0,
+    fieldValue: "",
     fieldRangeStart: 0,
     fieldRangeEnd: 0,
   },