Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pu): fix hppo entropy_weight to avoid nan error in log_prob #761

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

puyuan1996
Copy link
Collaborator

Description

  • fix hppo entropy_weight to avoid nan error in log_prob

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the bug Something isn't working label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4d53074) 77.11% compared to head (2cae4d8) 77.10%.
Report is 3 commits behind head on main.

Files Patch % Lines
ding/policy/ppo.py 0.00% 1 Missing ⚠️
ding/rl_utils/td.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   77.11%   77.10%   -0.01%     
==========================================
  Files         671      671              
  Lines       53676    53776     +100     
==========================================
+ Hits        41394    41466      +72     
- Misses      12282    12310      +28     
Flag Coverage Δ
unittests 77.10% <60.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PaParaZz1 PaParaZz1 merged commit d7a61c2 into opendilab:main Dec 29, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants