Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(rjy): polish comments in wqmix/ngu/pg model #739

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

nighood
Copy link
Collaborator

@nighood nighood commented Oct 18, 2023

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the doc Documentation label Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #739 (a9981fa) into main (817b215) will increase coverage by 0.13%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head a9981fa differs from pull request most recent head c385311. Consider uploading reports for the commit c385311 to get more accurate results

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   77.95%   78.09%   +0.13%     
==========================================
  Files         665      665              
  Lines       52179    52177       -2     
==========================================
+ Hits        40675    40746      +71     
+ Misses      11504    11431      -73     
Flag Coverage Δ
unittests 78.09% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ding/model/template/ngu.py 78.88% <ø> (ø)
ding/model/template/pg.py 94.11% <ø> (ø)
ding/model/template/wqmix.py 96.77% <ø> (+0.98%) ⬆️

... and 15 files with indirect coverage changes

ding/model/template/pg.py Outdated Show resolved Hide resolved
ding/model/template/wqmix.py Outdated Show resolved Hide resolved
ding/model/template/wqmix.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit c005205 into opendilab:main Oct 31, 2023
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants