Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(zc): add plan diffuser #700

Closed
wants to merge 25 commits into from
Closed

Conversation

Super1ce
Copy link
Contributor

@Super1ce Super1ce commented Aug 8, 2023

Description

add plan diffuser, add normalizer, add dataset

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the algo Add new algorithm or improve old one label Aug 8, 2023
ding/policy/command_mode_policy_instance.py Outdated Show resolved Hide resolved
dizoo/d4rl/entry/d4rl_dd_main.py Outdated Show resolved Hide resolved
config = Path(__file__).absolute().parent.parent / 'config' / args.config
config = read_config(str(config))
config[0].exp_name = config[0].exp_name.replace('0', str(args.seed))
serial_pipeline_offline(config, seed=args.seed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set max_train_iter

ding/policy/plan_diffuser.py Show resolved Hide resolved
@@ -0,0 +1,617 @@
from typing import Union, List, Dict
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can add some unit tests to make the code easier to understand.
And it's convenient to check the rightness for each module.

else:
return noise

def q_posterior(self, x_start, x_t, t):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comments and use cases

@PaParaZz1 PaParaZz1 changed the title feature(zc) : add plan diffuser feature(zc): add plan diffuser Aug 11, 2023
ding/entry/serial_entry_offline.py Outdated Show resolved Hide resolved
ding/model/template/__init__.py Outdated Show resolved Hide resolved
ding/policy/plan_diffuser.py Outdated Show resolved Hide resolved
ding/policy/plan_diffuser.py Outdated Show resolved Hide resolved
ding/utils/normalizer_helper.py Show resolved Hide resolved
ding/torch_utils/network/diffusion.py Outdated Show resolved Hide resolved
ding/torch_utils/network/diffusion.py Outdated Show resolved Hide resolved
ding/policy/plan_diffuser.py Show resolved Hide resolved
ding/policy/plan_diffuser.py Outdated Show resolved Hide resolved
ding/policy/plan_diffuser.py Outdated Show resolved Hide resolved
PaParaZz1 added a commit that referenced this pull request Oct 26, 2023
@PaParaZz1
Copy link
Member

This PR have been manually merged.

@PaParaZz1 PaParaZz1 closed this Oct 26, 2023

parser = argparse.ArgumentParser()
parser.add_argument('--seed', '-s', type=int, default=10)
parser.add_argument('--config', '-c', type=str, default='hopper_expert_cql_config.py')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认config应该改成plan diffuser相关的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants