Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(cy): add tensor stream merging tools #673

Merged
merged 4 commits into from
Jun 10, 2023

Conversation

Cloud-Pku
Copy link
Collaborator

Description

Some tools for merging tensor streams

Related Issue

TODO

Check List

  • [ √] merge the latest version source branch/repo, and resolve all the conflicts
  • [ √] pass style check
  • [ √] pass all the tests

@Cloud-Pku Cloud-Pku added the enhancement New feature or request label Jun 2, 2023
add unittest;
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #673 (e0522c9) into main (ebae45b) will decrease coverage by 0.50%.
The diff coverage is 46.98%.

❗ Current head e0522c9 differs from pull request most recent head a617df7. Consider uploading reports for the commit a617df7 to get more accurate results

@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
- Coverage   82.57%   82.08%   -0.50%     
==========================================
  Files         584      588       +4     
  Lines       47811    47630     -181     
==========================================
- Hits        39478    39095     -383     
- Misses       8333     8535     +202     
Flag Coverage Δ
unittests 82.08% <46.98%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/middleware/functional/logger.py 23.05% <14.28%> (-1.15%) ⬇️
ding/policy/bcq.py 22.58% <22.58%> (ø)
ding/model/template/bcq.py 25.37% <25.37%> (ø)
ding/utils/compression_helper.py 62.85% <28.57%> (-9.08%) ⬇️
ding/utils/lock_helper.py 85.71% <28.57%> (-7.27%) ⬇️
ding/utils/data/dataset.py 50.00% <46.15%> (-2.56%) ⬇️
ding/reward_model/pdeil_irl_model.py 83.33% <60.00%> (-2.99%) ⬇️
ding/world_model/ddppo.py 74.47% <60.00%> (-0.91%) ⬇️
ding/rl_utils/merge.py 84.44% <84.44%> (ø)
ding/model/template/__init__.py 100.00% <100.00%> (ø)
... and 5 more

... and 221 files with indirect coverage changes

ding/rl_utils/merge.py Outdated Show resolved Hide resolved
ding/rl_utils/merge.py Outdated Show resolved Hide resolved
ding/rl_utils/merge.py Outdated Show resolved Hide resolved
ding/rl_utils/merge.py Outdated Show resolved Hide resolved
ding/rl_utils/merge.py Outdated Show resolved Hide resolved
ding/rl_utils/tests/test_merge.py Outdated Show resolved Hide resolved
ding/rl_utils/tests/test_merge.py Outdated Show resolved Hide resolved
@PaParaZz1 PaParaZz1 merged commit faf4aab into opendilab:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants