Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(nyz): simplify requirements #672

Merged
merged 2 commits into from
May 31, 2023
Merged

polish(nyz): simplify requirements #672

merged 2 commits into from
May 31, 2023

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #672 (4c1c99c) into main (ebae45b) will decrease coverage by 0.50%.
The diff coverage is 29.45%.

❗ Current head 4c1c99c differs from pull request most recent head be254e7. Consider uploading reports for the commit be254e7 to get more accurate results

@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   82.57%   82.07%   -0.50%     
==========================================
  Files         584      586       +2     
  Lines       47811    47509     -302     
==========================================
- Hits        39478    38994     -484     
- Misses       8333     8515     +182     
Flag Coverage Δ
unittests 82.07% <29.45%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/framework/middleware/functional/logger.py 23.49% <0.00%> (-0.71%) ⬇️
ding/policy/bcq.py 22.58% <22.58%> (ø)
ding/model/template/bcq.py 25.37% <25.37%> (ø)
ding/utils/compression_helper.py 62.85% <28.57%> (-9.08%) ⬇️
ding/utils/lock_helper.py 85.71% <28.57%> (-7.27%) ⬇️
ding/utils/data/dataset.py 50.00% <46.15%> (-2.56%) ⬇️
ding/reward_model/pdeil_irl_model.py 83.33% <60.00%> (-2.99%) ⬇️
ding/world_model/ddppo.py 74.47% <60.00%> (-0.91%) ⬇️
ding/model/template/__init__.py 100.00% <100.00%> (ø)
ding/policy/__init__.py 100.00% <100.00%> (ø)
... and 2 more

... and 221 files with indirect coverage changes

@PaParaZz1 PaParaZz1 added the test Test(unittest, performance, efficiency, compatibility) label May 31, 2023
@PaParaZz1 PaParaZz1 merged commit 2ab7c44 into main May 31, 2023
@PaParaZz1 PaParaZz1 deleted the polish-requirement branch May 31, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Test(unittest, performance, efficiency, compatibility)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant