Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pu): fix last_linear_layer_weight_bias_init_zero in MLP and add its unittest #650

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

puyuan1996
Copy link
Collaborator

Description

fix last_linear_layer_weight_bias_init_zero in MLP and add its unittest

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added the bug Something isn't working label Apr 23, 2023
@puyuan1996 puyuan1996 added the test Test(unittest, performance, efficiency, compatibility) label Apr 23, 2023
ding/torch_utils/network/nn_module.py Outdated Show resolved Hide resolved
ding/torch_utils/network/nn_module.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #650 (dd238a2) into main (93e4fa5) will increase coverage by 0.01%.
The diff coverage is 92.68%.

❗ Current head dd238a2 differs from pull request most recent head 5a514fd. Consider uploading reports for the commit 5a514fd to get more accurate results

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   82.73%   82.74%   +0.01%     
==========================================
  Files         581      581              
  Lines       47587    47604      +17     
==========================================
+ Hits        39370    39390      +20     
+ Misses       8217     8214       -3     
Flag Coverage Δ
unittests 82.74% <92.68%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/torch_utils/network/nn_module.py 95.74% <78.57%> (+0.76%) ⬆️
ding/torch_utils/network/tests/test_nn_module.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 9e7002f into opendilab:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Test(unittest, performance, efficiency, compatibility)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants