Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(nyz): add PPOF ch4 reward demo suuport #608

Merged
merged 5 commits into from
Mar 10, 2023
Merged

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the enhancement New feature or request label Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #608 (4c2944e) into main (3b43ec0) will increase coverage by 0.00%.
The diff coverage is 27.11%.

@@           Coverage Diff            @@
##             main     #608    +/-   ##
========================================
  Coverage   83.35%   83.35%            
========================================
  Files         569      569            
  Lines       46696    46819   +123     
========================================
+ Hits        38922    39027   +105     
- Misses       7774     7792    +18     
Flag Coverage Δ
unittests 83.35% <27.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ding/bonus/config.py 0.00% <0.00%> (ø)
ding/bonus/ppof.py 0.00% <0.00%> (ø)
ding/framework/middleware/functional/trainer.py 85.71% <ø> (-0.40%) ⬇️
ding/envs/env/ding_env_wrapper.py 79.76% <61.53%> (-4.76%) ⬇️

... and 68 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 275141b into main Mar 10, 2023
@PaParaZz1 PaParaZz1 deleted the dev-ppof-ch4 branch March 10, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant