-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(wgt): add barrier middleware #570
Merged
PaParaZz1
merged 4 commits into
opendilab:main
from
SolenoidWGT:feature_add_nng_mq_barrier
Apr 16, 2023
Merged
feature(wgt): add barrier middleware #570
PaParaZz1
merged 4 commits into
opendilab:main
from
SolenoidWGT:feature_add_nng_mq_barrier
Apr 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolenoidWGT
force-pushed
the
feature_add_nng_mq_barrier
branch
from
January 12, 2023 05:46
22e204b
to
f226855
Compare
SolenoidWGT
force-pushed
the
feature_add_nng_mq_barrier
branch
from
January 12, 2023 07:35
f226855
to
923a678
Compare
SolenoidWGT
force-pushed
the
feature_add_nng_mq_barrier
branch
from
January 12, 2023 11:45
923a678
to
a334a0c
Compare
Codecov Report
@@ Coverage Diff @@
## main #570 +/- ##
==========================================
- Coverage 83.57% 82.69% -0.89%
==========================================
Files 562 581 +19
Lines 46009 47464 +1455
==========================================
+ Hits 38454 39249 +795
- Misses 7555 8215 +660
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 176 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
SolenoidWGT
force-pushed
the
feature_add_nng_mq_barrier
branch
3 times, most recently
from
January 13, 2023 07:28
c6a2d56
to
906e0c0
Compare
SolenoidWGT
force-pushed
the
feature_add_nng_mq_barrier
branch
from
January 17, 2023 06:34
906e0c0
to
860e901
Compare
PaParaZz1
changed the title
feature(wgt): Add barrier middleware
feature(wgt): add barrier middleware
Feb 2, 2023
PaParaZz1
requested changes
Feb 2, 2023
PaParaZz1
requested changes
Apr 13, 2023
PaParaZz1
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Barrier
is a middleware for debug or profiling. It can synchronize the task step of each process within the scope of all visible processes. When usingBarrier
, you need to pay attention to the following points:All processes must call the same number of
Barrier
, otherwise a deadlock occurs.'
attch_from_nums
' is a very important variable, This value indicates the number of times the current process will be attached to by other processes (the number of connections established). For example:Please note that this value must be given correctly, otherwise, for a node whose '
attach_to
' list is empty, it cannot perceive how many processes will establish connections with it, resulting in any form of synchronization cannot be performed.Barrier
is thread-safe, but it is not recommended to use barrier in multithreading. You need to carefully calculate the number of times each thread callsBarrier
to avoid deadlock.In normal training tasks, please do not use
Barrier
, which will force the step synchronization between each process, so it will greatly damage the training efficiency. In addition, if your training task has dynamic processes, do not useBarrier
to prevent deadlock.Check List