Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nyz): fix py38 unittest bugs #565

Merged
merged 18 commits into from
Jan 2, 2023
Merged

fix(nyz): fix py38 unittest bugs #565

merged 18 commits into from
Jan 2, 2023

Conversation

PaParaZz1
Copy link
Member

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@PaParaZz1 PaParaZz1 added the bug Something isn't working label Dec 28, 2022
@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Merging #565 (05a006b) into main (c30818a) will decrease coverage by 0.23%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   84.81%   84.57%   -0.24%     
==========================================
  Files         555      555              
  Lines       44673    45197     +524     
==========================================
+ Hits        37889    38226     +337     
- Misses       6784     6971     +187     
Flag Coverage Δ
unittests 84.57% <84.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/env_manager/tests/test_gym_vector_env_manager.py 25.00% <50.00%> (-75.00%) ⬇️
ding/data/level_replay/level_sampler.py 60.57% <66.66%> (+0.19%) ⬆️
ding/framework/middleware/tests/test_logger.py 60.10% <80.00%> (-29.31%) ⬇️
ding/envs/env_manager/tests/conftest.py 88.75% <87.50%> (-6.90%) ⬇️
...ng/envs/env_manager/tests/test_base_env_manager.py 100.00% <100.00%> (ø)
...s/env_manager/tests/test_subprocess_env_manager.py 71.89% <100.00%> (+0.62%) ⬆️
ding/framework/task.py 93.55% <100.00%> (+0.06%) ⬆️
ding/torch_utils/loss/multi_logits_loss.py 97.56% <100.00%> (ø)
ding/envs/env_manager/gym_vector_env_manager.py 25.88% <0.00%> (-69.42%) ⬇️
... and 214 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PaParaZz1 PaParaZz1 merged commit 29a3378 into main Jan 2, 2023
@PaParaZz1 PaParaZz1 deleted the fix-py38 branch January 2, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant