Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(rjy): add dmc2gym+sac baseline both in state input and pixel input #451

Merged
merged 25 commits into from
Mar 8, 2023

Conversation

nighood
Copy link
Collaborator

@nighood nighood commented Aug 19, 2022

Description

Related Issue

TODO

Check List

  • merge the latest version source branch/repo, and resolve all the conflicts
  • pass style check
  • pass all the tests

@puyuan1996 puyuan1996 added algo Add new algorithm or improve old one config Update config labels Aug 19, 2022
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #451 (df351a2) into main (741fe40) will increase coverage by 2.20%.
The diff coverage is 76.72%.

❗ Current head df351a2 differs from pull request most recent head a863579. Consider uploading reports for the commit a863579 to get more accurate results

@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   83.50%   85.71%   +2.20%     
==========================================
  Files         565      537      -28     
  Lines       46325    43055    -3270     
==========================================
- Hits        38684    36903    -1781     
+ Misses       7641     6152    -1489     
Flag Coverage Δ
unittests 85.71% <76.72%> (+2.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ework/middleware/functional/advantage_estimator.py 97.05% <ø> (+18.79%) ⬆️
ding/policy/sac.py 60.18% <69.23%> (-2.49%) ⬇️
ding/model/template/qac.py 83.05% <69.33%> (-10.09%) ⬇️
ding/model/common/head.py 99.20% <100.00%> (+2.34%) ⬆️
ding/model/template/__init__.py 100.00% <100.00%> (ø)
ding/model/template/tests/test_qac.py 98.13% <100.00%> (+0.45%) ⬆️
ding/torch_utils/loss/contrastive_loss.py 89.13% <0.00%> (-10.87%) ⬇️
...r/collector/battle_interaction_serial_evaluator.py 88.41% <0.00%> (-5.39%) ⬇️
ding/entry/cli_parsers/slurm_parser.py 90.27% <0.00%> (-4.07%) ⬇️
ding/envs/env_manager/tests/test_shm.py 88.46% <0.00%> (-3.54%) ⬇️
... and 231 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dizoo/rocket/config/rocket_ppo_config.py Outdated Show resolved Hide resolved
dizoo/dmc2gym/config/dmc2gym_sac_state_config.py Outdated Show resolved Hide resolved
dizoo/dmc2gym/config/dmc2gym_sac_state_config.py Outdated Show resolved Hide resolved
dizoo/dmc2gym/config/dmc2gym_sac_pixel_config.py Outdated Show resolved Hide resolved
dizoo/dmc2gym/config/dmc2gym_sac_pixel_config.py Outdated Show resolved Hide resolved
ding/policy/sac.py Show resolved Hide resolved
@PaParaZz1 PaParaZz1 changed the title WIP: feature(rjy): add dmc2gym+sac baseline both in state input and pixel input feature(rjy): add dmc2gym+sac baseline both in state input and pixel input Mar 7, 2023
@PaParaZz1 PaParaZz1 merged commit 8e9ecaf into opendilab:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo Add new algorithm or improve old one config Update config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants