Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to opendesign/psd-ts #18

Closed

Conversation

rychlis
Copy link
Contributor

@rychlis rychlis commented Dec 12, 2022

had to do this change to be actually able to use octopus-psd with our webtoon fork of psd parser

@rychlis
Copy link
Contributor Author

rychlis commented Dec 12, 2022

related pr: opendesigndev/psd-ts#2

@rychlis
Copy link
Contributor Author

rychlis commented Dec 12, 2022

if you see a better way - i guess you could add the linked psd-ts in files in package.json, but that seems like a hack to me. Maybe @CodeWitchBella would have other idea?

@CodeWitchBella
Copy link
Contributor

CodeWitchBella commented Dec 12, 2022

LGTM. One possible alternative, which would make it easier to switch back to upstream version would be to use "@webtoon/psd": "npm:@opendesign/psd-ts@version" spec in dependencies in package.json.

Though I am not sure how well it is supported across npm, yarn and pnpm, since this is a library...

@CodeWitchBella
Copy link
Contributor

Another option would be to use package.json#imports, which would also allow remapping this in package.json. But it's not supported in vite which makes it a no-go, unfortunatelly.

@rychlis rychlis force-pushed the rychlis/opendesign-psdts branch from cfaeb37 to e0d7e17 Compare December 14, 2022 05:40
@rychlis
Copy link
Contributor Author

rychlis commented Dec 14, 2022

i tried the npm:@opendesign/psd-ts@version approach and it seems to be working well., at least in lambda #21

@rychlis rychlis closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants