Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1. resolve uncorrect pair relation of figure and footnote, 2. resolve uncorrect pair relation of table and caption #590 #599

Merged

Conversation

icecraft
Copy link
Collaborator

@icecraft icecraft commented Sep 12, 2024

fix:

  1. resolve uncorrect pair relation of figure and footnote
  2. resolve uncorrect pair relation of table and caption layout.pdf结果和layout模型结果不一致 #590

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

fix the match algorithm of caption and [ figure | table ]

Modification

fix the match algorithm of caption and [figure | table] that leads magic_pdf/models/magic_models.py changed

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@myhloli myhloli changed the title fix: 1. resolve uncorrect pair relation of figure and footnote, 2. re… fix: 1. resolve uncorrect pair relation of figure and footnote, 2. resolve uncorrect pair relation of table and caption #590 Sep 12, 2024
@myhloli myhloli merged commit c95f381 into opendatalab:master Sep 12, 2024
2 of 3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@icecraft icecraft deleted the fix/uncorrect_figure_footnote_relation branch November 8, 2024 08:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants