Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMD Dockerfile additions #168

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

RH-steve-grubb
Copy link

This sets the vllm build to a Release build type, builds libsodium,
fixes bad permissions on a logging directory, installs libsodium, and adds a LD_LIBRARY_PATH to fixup python bindings for 2 packages.

fixes bad permissions on a logging directory, installs libsodium,
and adds a LD_LIBRARY_PATH to fixup python bindings for 2 packages.
Dockerfile.rocm.ubi Show resolved Hide resolved
Dockerfile.rocm.ubi Outdated Show resolved Hide resolved
This moves the install up a couple lines.
The /var/log/rocm_smi_lib/ directory was world writable. It
is fixed now so that it is world readable. Similarly,
the file in it's directory is also world writable, it is
now world readable.
Copy link

openshift-ci bot commented Sep 26, 2024

@RH-steve-grubb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test ae1811a link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, NickLucche, RH-steve-grubb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [NickLucche,RH-steve-grubb,dtrifiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NickLucche NickLucche merged commit d19c747 into opendatahub-io:main Sep 27, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants