-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMD Dockerfile additions #168
AMD Dockerfile additions #168
Conversation
fixes bad permissions on a logging directory, installs libsodium, and adds a LD_LIBRARY_PATH to fixup python bindings for 2 packages.
This moves the install up a couple lines.
The /var/log/rocm_smi_lib/ directory was world writable. It is fixed now so that it is world readable. Similarly, the file in it's directory is also world writable, it is now world readable.
@RH-steve-grubb: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtrifiro, NickLucche, RH-steve-grubb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This sets the vllm build to a Release build type, builds libsodium,
fixes bad permissions on a logging directory, installs libsodium, and adds a LD_LIBRARY_PATH to fixup python bindings for 2 packages.