Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile.ubi.rocm: fix build #167

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

dtrifiro
Copy link

@dtrifiro dtrifiro commented Sep 25, 2024

  • move microdnf update in base stage
  • bump torch version to 2.5.0.dev20240912+rocm6.1
  • get rid of build triton stage: it's installed as part of torch when installing from the amd/rocm6.1 index (https://download.pytorch.org/whl/nightly/rocm6.1)

@RH-steve-grubb
Copy link

This fixes a conflict where installing triton resolves to an nvidia package which is clearly wrong.
/lgtm

Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, RH-steve-grubb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [RH-steve-grubb,dtrifiro]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@NickLucche
Copy link

good job!

@RH-steve-grubb
Copy link

/lgtm

Copy link

openshift-ci bot commented Sep 25, 2024

@dtrifiro: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/smoke-test 399c114 link true /test smoke-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RH-steve-grubb RH-steve-grubb merged commit 9ebf28d into opendatahub-io:main Sep 25, 2024
19 of 21 checks passed
@dtrifiro dtrifiro deleted the fix-amd-build branch September 26, 2024 07:37
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
riprasad pushed a commit to red-hat-data-services/vllm that referenced this pull request Oct 25, 2024
* Reimplement silu and mul in mixtral

* Typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants