Skip to content

Commit

Permalink
[Bugfix] Validate SamplingParam n is an int (vllm-project#8548)
Browse files Browse the repository at this point in the history
  • Loading branch information
saumya-saran authored and dtrifiro committed Sep 27, 2024
1 parent 1fff372 commit 82df51f
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion vllm/sampling_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,14 @@ def __post_init__(self) -> None:
self._all_stop_token_ids = set(self.stop_token_ids)

def _verify_args(self) -> None:
if not isinstance(self.n, int):
raise ValueError(f"n must be an int, but is of "
f"type {type(self.n)}")
if self.n < 1:
raise ValueError(f"n must be at least 1, got {self.n}.")
assert isinstance(self.best_of, int)
if not isinstance(self.best_of, int):
raise ValueError(f'best_of must be an int, but is of '
f'type {type(self.best_of)}')
if self.best_of < self.n:
raise ValueError(f"best_of must be greater than or equal to n, "
f"got n={self.n} and best_of={self.best_of}.")
Expand Down

0 comments on commit 82df51f

Please sign in to comment.