Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for vllm v0.6.4 #183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updates for vllm v0.6.4 #183

wants to merge 3 commits into from

Conversation

tjohnson31415
Copy link
Contributor

vLLM v0.6.4 has been released. This PR is to make changes to the adapter to support this new release.

TODO: I only noticed this one change and wanted to make a commit out of it. More testing should be done to see if additional changes are needed.

Description

  • remove use of deprecated LLMInputs that is now just a type instead of a class REF
  • TODO

How Has This Been Tested?

Manually tested by running the changed code with vLLM v0.6.4 installed.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.46%. Comparing base (2c80c72) to head (702ef9a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   62.46%   62.46%           
=======================================
  Files          28       28           
  Lines        1721     1721           
  Branches      211      211           
=======================================
  Hits         1075     1075           
  Misses        544      544           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@prashantgupta24 prashantgupta24 marked this pull request as ready for review November 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants