Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kserve:main #14

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 17, 2023

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Add help texts to Makefile targets:

  all             Alias for `build`
  build           Build runtime Docker image
  build.develop   Build develop container image
  develop         Run interactive shell inside developer container
  fmt             Auto-format source code and report code-style violations (lint)
  help            Print Makefile documentation
  run             Run make target inside developer container (e.g. `make run fmt`)
  test            Run tests

---------

Signed-off-by: ddelange <[email protected]>
@openshift-ci openshift-ci bot requested review from heyselbi and Jooho August 17, 2023 03:42
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign vedantmahabaleshwarkar for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vaibhavjainwiz vaibhavjainwiz merged commit c818bc5 into opendatahub-io:main Aug 24, 2023
3 checks passed
openshift-ci bot pushed a commit that referenced this pull request Oct 6, 2023
Resolves #14 
Resolves kserve/modelmesh-serving#418

---------

Signed-off-by: Rafael Vasquez <[email protected]>
spolti pushed a commit to spolti/rest-proxy that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants