chore(cleanup): remove checkDependentOperators as duplicated logic #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- both depedent operators have been check in configureServerlessFeatures Signed-off-by: Wen Zhou <[email protected]>
ykaliuta
approved these changes
May 2, 2024
cam-garrison
approved these changes
May 2, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cam-garrison, ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 55320b6
into
opendatahub-io:incubation
8 checks passed
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jun 18, 2024
…pendatahub-io#996) - both depedent operators have been check in configureServerlessFeatures Signed-off-by: Wen Zhou <[email protected]>
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jun 26, 2024
…pendatahub-io#996) - both depedent operators have been check in configureServerlessFeatures Signed-off-by: Wen Zhou <[email protected]>
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jun 26, 2024
…pendatahub-io#996) - both depedent operators have been check in configureServerlessFeatures Signed-off-by: Wen Zhou <[email protected]>
zdtsw
added a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Jul 9, 2024
…logic (opendatahub-io#996)" This reverts commit 55320b6.
bartoszmajsak
pushed a commit
to bartoszmajsak/opendatahub-operator
that referenced
this pull request
Jul 10, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 11, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
zdtsw
added a commit
to zdtsw-forking/rhods-operator
that referenced
this pull request
Jul 19, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
openshift-merge-bot bot
pushed a commit
to red-hat-data-services/rhods-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6.
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6. (cherry picked from commit 011c946)
VaishnaviHire
pushed a commit
to VaishnaviHire/opendatahub-operator
that referenced
this pull request
Jul 24, 2024
…logic (opendatahub-io#996)" (opendatahub-io#1107) This reverts commit 55320b6. (cherry picked from commit 011c946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have checkDependentOperators to check both servicemesh and serverless operator
but also in configureServerlessFeatures we have
Description
How Has This Been Tested?
Merge criteria: