Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gh): ensures unit-test action uses go.mod for Go version #689

Merged
merged 2 commits into from
Nov 2, 2023
Merged

chore(gh): ensures unit-test action uses go.mod for Go version #689

merged 2 commits into from
Nov 2, 2023

Conversation

bartoszmajsak
Copy link
Contributor

Description

To keep it DRY

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@bartoszmajsak bartoszmajsak requested review from zdtsw and removed request for etirelli November 1, 2023 14:10
zdtsw
zdtsw approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@zdtsw zdtsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zdtsw
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Nov 2, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 2, 2023

New changes are detected. LGTM label has been removed.

@bartoszmajsak bartoszmajsak changed the title chore(gh): ensures go version used by unit-tests matches project settings chore(gh): ensures unit-test action references go.mod for Go version Nov 2, 2023
@zdtsw zdtsw added the odh-2.4 label Nov 2, 2023
@bartoszmajsak bartoszmajsak changed the title chore(gh): ensures unit-test action references go.mod for Go version chore(gh): ensures unit-test action uses go.mod for Go version Nov 2, 2023
@bartoszmajsak bartoszmajsak merged commit d356d80 into incubation Nov 2, 2023
6 of 7 checks passed
@bartoszmajsak bartoszmajsak deleted the gh-unit-tests-go-version branch November 2, 2023 10:16
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
@bartoszmajsak @VaishnaviHire
chore(gh): ensures unit-test action uses go.mod for Go version (opend…
af89afc 
…atahub-io#689)

(cherry picked from commit d356d80)
@VaishnaviHire VaishnaviHire mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdtsw zdtsw zdtsw approved these changes

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees

@zdtsw zdtsw

Labels
odh-2.4
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartoszmajsak @zdtsw