Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport(workbench): support images in two path for downstream #663

Merged
merged 2 commits into from
Nov 2, 2023
Merged

backport(workbench): support images in two path for downstream #663

merged 2 commits into from
Nov 2, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 25, 2023 •
edited
Loading

relate to red-hat-data-services/kubeflow#29
ref: #579

this is backport from downstream logic and only add for downstream logic which is already in place

Description

How Has This Been Tested?

cherrypick kubeflow pr 29
local build: quay.io/wenzhou/opendatahub-operator:dev-2.10.579-29
check params.env

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign etirelli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw marked this pull request as ready for review October 25, 2023 08:57
@zdtsw zdtsw mentioned this pull request Oct 25, 2023
Merged
@zdtsw
Copy link
Member Author

zdtsw commented Oct 25, 2023

/unhold

@zdtsw
Copy link
Member Author

zdtsw commented Oct 26, 2023

/test opendatahub-operator-e2e

1 similar comment
@zdtsw
Copy link
Member Author

zdtsw commented Oct 30, 2023

/test opendatahub-operator-e2e

@zdtsw zdtsw added odh-2.4 and removed odh-1.11 labels Oct 31, 2023
@zdtsw zdtsw changed the title add(workbench): support images in two path add(workbench): support images in two path for downstream Nov 2, 2023
@zdtsw zdtsw enabled auto-merge (squash) November 2, 2023 08:35
@zdtsw zdtsw changed the title add(workbench): support images in two path for downstream backport(workbench): support images in two path for downstream Nov 2, 2023
@zdtsw zdtsw merged commit 09c0785 into opendatahub-io:incubation Nov 2, 2023
6 of 7 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
@zdtsw @VaishnaviHire
backport(workbench): support images in two path in downstream (openda…
4b764a4 
…tahub-io#663)

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 09c0785)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaVLaS LaVLaS Awaiting requested review from LaVLaS

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees
No one assigned
Labels
odh-2.4 rhods-2.4
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zdtsw