Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sync]: change from incubation to rhoai + dummy change #1357

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[sync]: change from incubation to rhoai + dummy change #1357

merged 3 commits into from
Nov 11, 2024

Commits on Nov 8, 2024

  1. fix: ensure input CAbundle always end with a newline (opendatahub-io#… 

    …1339)

* fix: ensure input CAbundle always end with a newline

- missing newline will cause problem when inject data into configmap
- this happens when user use kustomize with their own CA for DSCI, it set to use |- not |
- fix lint

Signed-off-by: Wen Zhou <[email protected]>

* update: better way to add newline

Signed-off-by: Wen Zhou <[email protected]>

---------

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit 656d53e)
    @zdtsw
    zdtsw committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7f78d72 View commit details
    Browse the repository at this point in the history

  2. fix: add check to remove old kube-rbac-proxy container in modelregist… 

    …ry operator, fixes RHOAIENG-15328 (opendatahub-io#1341)

* fix: add check to remove old kube-rbac-proxy container in modelregistry operator, fixes RHOAIENG-15328

Signed-off-by: Dhiraj Bokde <[email protected]>

* update: remove check in ModelReg code, add it to upgrade logic

Signed-off-by: Wen Zhou <[email protected]>

---------

Signed-off-by: Dhiraj Bokde <[email protected]>
Signed-off-by: Wen Zhou <[email protected]>
Co-authored-by: Wen Zhou <[email protected]>
(cherry picked from commit 92251e4)
    @dhirajsb @zdtsw
    dhirajsb authored and zdtsw committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    a5771c8 View commit details
    Browse the repository at this point in the history

  3. fix: cherry-pick error 

    - remove new logger
- dummy: request from devops to verify auto-sync

Signed-off-by: Wen Zhou <[email protected]>
    @zdtsw
    zdtsw committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    975469f View commit details
    Browse the repository at this point in the history