Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: use namespace dyniamically from operator env than hardcode value #1298

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 11, 2024

Description

  • thses 2 fallbacked cases are only needed when it is downstream speicificly

relate but not to fix https://issues.redhat.com/browse/RHOAIENG-14308

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- thses are only needed when it is downstream speicific cases

Signed-off-by: Wen Zhou <[email protected]>
@zdtsw zdtsw requested review from ykaliuta and VaishnaviHire and removed request for CFSNM October 11, 2024 16:01
Copy link

openshift-ci bot commented Oct 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fa63b4d into opendatahub-io:incubation Oct 11, 2024
8 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Oct 18, 2024
…lue (opendatahub-io#1298)

- thses are only needed when it is downstream speicific cases

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit fa63b4d)
openshift-merge-bot bot pushed a commit to red-hat-data-services/rhods-operator that referenced this pull request Oct 18, 2024
…lue (opendatahub-io#1298)

- thses are only needed when it is downstream speicific cases

Signed-off-by: Wen Zhou <[email protected]>
(cherry picked from commit fa63b4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants